Windows support hacks #18
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hi, I am no longer using Knife Block at work and I do not have time to maintain it in my spare time owing to my personal life. If you wish to submit a patch, please do so and I will get around to merging it when I can. Sorry for any inconvenience. Matt |
|
@gmanfunky would you be interested in trying to rebase this and see if things still work? |
Open
|
Who owns the published gem, at present? I would like to see Windows support in the officially published gem. Is there more we can do to assist in making knife block windows compatible? It would ease the burden of workstation deployment and maintenance in restricted equipment environments. |
|
I am one of the maintainers. There is a branch and/or PR with some changes
to allow Windows compatibility. This might be it iirc. If you can certify
that it does allow Windows compatability I can test the Linux usage is
still working and I can merge it. Or you can propose your own PR.
…On 23 Sep 2017 09:33, "David Hayden" ***@***.***> wrote:
Who owns the published gem, at present? I would like to see Windows
support in the officially published gem. Is there more we can do to assist
in making knife block windows compatible?
—
You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHub
<#18 (comment)>,
or mute the thread
<https://github.com/notifications/unsubscribe-auth/AI-yG53hckIWI3kn1VDhGbf21pCo4_JRks5slG4VgaJpZM4Bt5xX>
.
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I really wanted to use knife-block on windows. So i came up with some kinda ugly hacks to make it work by redefining some File class method to shell out to the mklink cmd.exe function.
I also changed
def get_config_fileto just return any found config file and moved the Dirname logic to the callee to match the function name and similar knife function. I also provided a default config directory for cases when knife.rb does not exist.I did not test this on OSX after my changes. please check on OSX before publishing.
Mind bumping the version and publishing a new gem?