[Feature Request] Deployment clean-up

[ChrisLahaye]

Hello,

It would be nice if there was an extra flag, e.g. --rm, to delete the deployment when the process exits.

Thank you for creating this plugin.

[knight42]

@ChrisLahaye Hi! I am glad that you like this plugin!

This feature is easy to implement, but before getting to work on it I am curious about why you need to clean up the krelay-server Deployment? This Deployment is to be re-used by design, so that the next time we execute kubectl relay ... we don't need to wait for the creation of krelay-server.

[ChrisLahaye]

@ChrisLahaye Hi! I am glad that you like this plugin!

This feature is easy to implement, but before getting to work on it I am curious about why you need to clean up the krelay-server Deployment? This Deployment is to be re-used by design, so that the next time we execute kubectl relay ... we don't need to wait for the creation of krelay-server.

We are using krelay-server as a bastion host, so to access a host that is only accessible from the network of the kubernetes cluster. We are doing this very rarely on our cluster and don't want to leave unregistered resources and processes running on the cluster.

I think in general it would be good practice to provide a clean-up option that destroys the resources the tool created, even better if it is done in the same process in a transient way, like docker run --rm.

Thank you for your consideration.

[knight42]

@ChrisLahaye Hi! Thanks for your explanation, I will implement this feature in a few days 🚀

[knight42]

@ChrisLahaye Hi! Please try out the latest version v0.0.3 and feel free to report any issues.

[ChrisLahaye]

Hi @knight42,

I have a few more remarks:

• The deployment (when running without --rm) makes 3 pods, is this really necessary, or is a single pod sufficient? Maybe the number of replicas should default to one and be configurable.
• There is still no way to destroy the deployment that has been created when running without --rm.

The --rm for me personally solves all my issues, but I do believe above remarks would be welcome additions, so just leaving it here for thought.

Thank you!

[knight42]

@ChrisLahaye

The deployment makes 3 pods, is this really necessary

Technically a single pod is sufficient, but the krelay-server Deployment is meant to be reusable, so I want to make it high available.

There is still no way to destroy the deployment that has been created when running without --rm.

Yes you are right, and the reason is that somebody else might be still using this Deployment, and removing it might break others' connection.

Thanks for your advice!

[knight42]

@ChrisLahaye Hi! just in case you might be interested, now that krelay is able to specify the namespace of the krelay-server, so creating Deployment does not make much sense now(the deployment cannot always be reused) and using a single pod could simplify how krelay works. Therefore I decided to switch to a single pod and delete it afterwards, that said, --rm is now a default behavior and that flag has no effect and might be removed later.