Add TopologySpreadConstraints to server pod #27
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
knight42
approved these changes
Mar 13, 2024
Yes. Honestly I'm quite surprised it doesn't already. What's blocking that? 🤔 |
Well it used to, but some users want to cleanup the server pod afterwards, so I change the default behavior. It seems both behaviors are desired, we'd better leave the choice to users. |
|
@ilpianista Hi, |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Partially related to issue #24, we've exhausted the IPs in a single EC2 instance because all krelay servers where deployed to the same k8s node. We already setup a "krelay killer", but this could happen again if devs starts krelay servers without killing them in a short interval. Maybe a topologySpreadConstraints would make this problem a rare occurrence?