Fixed possible buffer overflow + various Win32/MSVC build fixes + Win32 Unicode support

[lordmulder]

Please see here for details:
https://sourceforge.net/p/faac/discussion/general/thread/f0e39f16/

[knik0]

It looks like faad_fopen is undefined, probably only defined in Windows.

[lordmulder]

Thanks for reply.

It is defined in my unicode_support.h file, and implemented in unicode_support.c:
435ec28#diff-68ac2deccaccc19956ff4720b6566ab5

Note: This is pretty much the same code that I developed for and contributed to Opus-Tools:
https://git.xiph.org/?p=opus-tools.git;a=blob;f=win32/unicode_support.c;h=f057ac04077667bce3502c4b7f2d1b9c6951baa5;hb=HEAD

---

[EDIT]

unicode_support.h contains #defines that map faad_fopen() to fopen() on POSIX platforms.

[knik0]

Is is save to include it on all platforms, in the patch it's only included in windows.

[lordmulder]

Is is save to include it on all platforms, in the patch it's only included in windows.

Yes, should be safe. Including it only on Win32 was my mistake, sorry.

---

Maybe the guard in unicode_support.h should be changed from:

#ifdef _WIN32
...
#else
...
#endif

...to:

#if defined WIN32 || defined _WIN32 || defined WIN64 || defined _WIN64
...
#else
...
#endif

Also, the function prototypes defined above should be inside the guard, I suppose.

[lordmulder]

I have updated the code.