ignore return value of Task.cancel().

sartography · Aug 23, 2012 · 5273cd3 · 5273cd3
1 parent ba93fb0
commit 5273cd3
Show file tree

Hide file tree

Showing 2 changed files with 1 addition and 10 deletions.
diff --git a/SpiffWorkflow/Task.py b/SpiffWorkflow/Task.py
@@ -578,7 +578,7 @@ def cancel(self):
             return
         self._set_state(self.CANCELLED)
         self._drop_children()
-        return self.task_spec._on_cancel(self)
+        self.task_spec._on_cancel(self)
 
     def complete(self):
         """

diff --git a/SpiffWorkflow/specs/TaskSpec.py b/SpiffWorkflow/specs/TaskSpec.py
@@ -340,8 +340,6 @@ def _on_ready_before_hook(self, my_task):
 
         @type  my_task: Task
         @param my_task: The associated task in the task tree.
-        @rtype:  boolean
-        @return: True on success, False otherwise.
         """
         pass
 
@@ -351,8 +349,6 @@ def _on_ready_hook(self, my_task):
 
         @type  my_task: Task
         @param my_task: The associated task in the task tree.
-        @rtype:  boolean
-        @return: True on success, False otherwise.
         """
         pass
 
@@ -361,15 +357,10 @@ def _on_cancel(self, my_task):
         May be called by another task to cancel the operation before it was
         completed.
 
-        Return True on success, False otherwise.
-
         @type  my_task: Task
         @param my_task: The associated task in the task tree.
-        @rtype:  boolean
-        @return: True on success, False otherwise.
         """
         self.cancelled_event.emit(my_task.workflow, my_task)
-        return True
 
     def _on_trigger(self, my_task):
         """