Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow new Square shape #6

Closed
knitcodemonkey opened this issue Oct 28, 2019 · 4 comments
Closed

Allow new Square shape #6

knitcodemonkey opened this issue Oct 28, 2019 · 4 comments
Assignees
Labels
enhancement New feature or request good first issue Good for newcomers

Comments

@knitcodemonkey
Copy link
Owner

knitcodemonkey commented Oct 28, 2019

Issue

Current Behavior

Hexagon is the only shape

Desired Behavior

Add a Square shape:

[ ] Add a form select to include Square
[ ] Create a Square component
[ ] Allow prop to load either the Hexagon or Square layout
[ ] Default to Hexagon

@knitcodemonkey knitcodemonkey added enhancement New feature or request good first issue Good for newcomers labels Oct 28, 2019
@knitcodemonkey knitcodemonkey changed the title Allow new shapes Allow new Square shape Oct 28, 2019
@izhuravlev
Copy link
Contributor

I can take a look at it

@izhuravlev
Copy link
Contributor

@knitcodemonkey do you want them to be in form of squares (top and bottom are parallel to the horizon) or like rhombuses (squares turned 45 degrees)?

@knitcodemonkey
Copy link
Owner Author

knitcodemonkey commented Oct 29, 2019

@izhuravlev, thank you for checking! I would like squares with the top and bottom perpendicular to the left and right, please. I believe we can just create a <Square /> component so we can switch between <Square /> and <Hexagon /> based on a menu selection.

Example of an actual quilt:

image

@izhuravlev
Copy link
Contributor

@knitcodemonkey on it!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request good first issue Good for newcomers
Projects
None yet
Development

No branches or pull requests

2 participants