restore saved previous server (Cockatrice#4206)

fix Cockatrice#3617
knitknit · Jan 2, 2021 · 8226054 · 8226054
1 parent 8879ce4
commit 8226054
Show file tree

Hide file tree

Showing 2 changed files with 5 additions and 3 deletions.
diff --git a/cockatrice/src/dlg_connect.cpp b/cockatrice/src/dlg_connect.cpp
@@ -193,12 +193,13 @@ void DlgConnect::rebuildComboBoxList(int failure)
     savedHostList = uci.getServerInfo();
 
     bool autoConnectEnabled = static_cast<bool>(SettingsCache::instance().servers().getAutoConnect());
+    QString previousHostName = SettingsCache::instance().servers().getPrevioushostName();
     QString autoConnectSaveName = SettingsCache::instance().servers().getSaveName();
 
     int index = 0;
 
     for (const auto &pair : savedHostList) {
-        auto tmp = pair.second;
+        const auto &tmp = pair.second;
         QString saveName = tmp.getSaveName();
         if (saveName.size()) {
             previousHosts->addItem(saveName);
@@ -207,7 +208,7 @@ void DlgConnect::rebuildComboBoxList(int failure)
                 if (saveName.compare(autoConnectSaveName) == 0) {
                     previousHosts->setCurrentIndex(index);
                 }
-            } else if (saveName.compare("Rooster Ranges") == 0) {
+            } else if (saveName.compare(previousHostName) == 0) {
                 previousHosts->setCurrentIndex(index);
             }
 

diff --git a/cockatrice/src/settings/serverssettings.cpp b/cockatrice/src/settings/serverssettings.cpp
@@ -50,7 +50,8 @@ QString ServersSettings::getSite(QString defaultSite)
 
 QString ServersSettings::getPrevioushostName()
 {
-    return getValue("previoushostName", "server").toString();
+    QVariant value = getValue("previoushostName", "server");
+    return value == QVariant() ? "Rooster Ranges" : value.toString();
 }
 
 int ServersSettings::getPrevioushostindex(const QString &saveName)