fix: minor template issues preventing a clean install #3
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hey @knmsk , I've been tracking your PR on https://github.com/grafana/k6-operator/pull/98/files
First, thank you for doing this work; it saved me a ton of time to get the k6-operator installed via Helm!
I tried to install this in a new cluster by running
helm install ./path/topackage.tgz, I kept getting small template formatting issues that I could fix by seeing the install output with--dry-runflagWith these fixes, I can get a clean install, and I successfully ran a k6 test via k8s using the newly installed operator.
I thought about proposing the changes here as I believe they can be helpful in reducing a few more bugs in the main PR linked above.
Have a good one!