Clean up most external reference when disposing a computed. fixes #1405

knockout · Dec 4, 2016 · b13ffb0 · b13ffb0
1 parent 2f230dc
commit b13ffb0
Showing 1 changed file with 7 additions and 2 deletions.
diff --git a/src/subscribables/dependentObservable.js b/src/subscribables/dependentObservable.js
@@ -355,12 +355,17 @@ var computedFn = {
         if (state.disposeWhenNodeIsRemoved && state.domNodeDisposalCallback) {
             ko.utils.domNodeDisposal.removeDisposeCallback(state.disposeWhenNodeIsRemoved, state.domNodeDisposalCallback);
         }
-        state.dependencyTracking = null;
+        state.dependencyTracking = undefined;
         state.dependenciesCount = 0;
         state.isDisposed = true;
         state.isStale = false;
         state.isSleeping = false;
-        state.disposeWhenNodeIsRemoved = null;
+        state.disposeWhenNodeIsRemoved = undefined;
+        state.disposeWhen = undefined;
+        state.readFunction = undefined;
+        if (!this.hasWriteFunction) {
+            state.evaluatorFunctionTarget = undefined;
+        }
     }
 };