Made the binding processing errors prettier #1633
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…anonymous function. This was made possible by making the wrapping function a named function instead of an anonymous function, and then removing it only if it has the right name.
brianmhunt
added a commit
to brianmhunt/knockout
that referenced
this pull request
Nov 26, 2014
|
Thanks @mariusGundersen -- I have incorporated changes along the lines of what you have asked for into the #1628 PR. On the basis that it mostly hits the mark for what you're asking here, I'll close this PR (and related issue), but do let me know if you think I've overlooked or misunderstood anything, or improvements could be made. Cheers |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Made the binding processing errors prettier by removing the wrapping anonymous function. This was made possible by making the wrapping function a named function instead of an anonymous function, and then removing it only if it has the right name. This fixes #1632