Component named "watch" will give an error in Firefox #1756
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Object's in Firefox have a watch property (https://developer.mozilla.org/en-US/docs/Web/JavaScript/Reference/Global_Objects/Object/watch). Our check to see if something is registered should do |
rniemeyer
force-pushed
the
1756-hasOwnProperty-in-component-register-check
branch
from
ff6a39b
to
04596e8
Compare
|
Code added to this issue. |
|
I made a small addition to the test. Otherwise looks great. |
|
Looks good @mbest |
SteveSanderson
added a commit
that referenced
this pull request
Apr 9, 2015
…nt-register-check Component named "watch" will give an error in Firefox
|
Excellent - thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Naming a component
watchgives the following warning in Firefox 37:Error: Component watch is already registeredI've created a gist of a barebones application which demonstrates this:
https://gist.github.com/msteward/c3a0298322277adae29e
This error is not thrown in Chrome or IE. For now I can choose another name but curious as to why this would fail in only Firefox?