Hide or don't minify extra internal properties on binding context #2296
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
It is possible for properties such as `_subscribable` to be created on a binding context, which, after minification, could be renamed to any arbitrary character. In most cases this is not an issue, except when a global variable with the same name exists, however rare the case may be. This causes the global variable to be shadowed in all bindings, which is especially problematic in the case of, say, `$`, which breaks jquery. To fix this, either hide such properties with a Symbol, or simply don't minify them so that the name is constant and predictable. Fixes knockout#2294
|
Thanks the contribution. This looks good! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It is possible for properties such as
_subscribableto be created on abinding context, which, after minification, could be renamed to any
arbitrary character. In most cases this is not an issue, except when a
global variable with the same name exists, however rare the case may be.
This causes the global variable to be shadowed in all bindings, which is
especially problematic in the case of, say,
$, which breaks jquery.To fix this, either hide such properties with a Symbol, or simply don't
minify them so that the name is constant and predictable.
Fixes #2294