#5 c29a923 79d3f5f

knockout · Dec 16, 2017 · be67572 · be67572
1 parent 6cc40eb
commit be67572
Show file tree

Hide file tree

Showing 2 changed files with 9 additions and 5 deletions.
diff --git a/...tko.binding.core/spec/visibleBehaviors.js → ...nding.core/spec/visibleHiddenBehaviors.js b/...tko.binding.core/spec/visibleBehaviors.js → ...nding.core/spec/visibleHiddenBehaviors.js
@@ -27,7 +27,7 @@ describe('Binding: Visible', function () {
     provider.bindingHandlers.set(coreBindings)
   })
 
-  it('Should display the node only when the value is true', function () {
+  it('Visible means the node only when the value is true', function () {
     var myObservable = observable(false)
     testNode.innerHTML = "<input data-bind='visible:myModelProperty()' />"
     applyBindings({
@@ -39,7 +39,7 @@ describe('Binding: Visible', function () {
     expect(testNode.childNodes[0].style.display).toEqual('')
   })
 
-  it('Should unwrap observables implicitly', function () {
+  it('Visible should unwrap observables implicitly', function () {
     var myObservable = observable(false)
     testNode.innerHTML = "<input data-bind='visible:myModelProperty' />"
     applyBindings({

diff --git a/packages/tko.binding.core/src/visible.js b/packages/tko.binding.core/src/visible.js
@@ -5,13 +5,17 @@ import {
 export var visible = {
   update: function (element, valueAccessor) {
     var value = unwrap(valueAccessor())
-    var isCurrentlyVisible = !(element.style.display == 'none')
-    if (value && !isCurrentlyVisible) { element.style.display = '' } else if ((!value) && isCurrentlyVisible) { element.style.display = 'none' }
+    var isCurrentlyVisible = !(element.style.display === 'none')
+    if (value && !isCurrentlyVisible) {
+      element.style.display = ''
+    } else if (!value && isCurrentlyVisible) {
+      element.style.display = 'none'
+    }
   }
 }
 
 export var hidden = {
   update: function (element, valueAccessor) {
-    visible.update.call(this, element, function () { return !unwrap(valueAccessor()) })
+    visible.update.call(this, element, () => !unwrap(valueAccessor()))
   }
 }