Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

removing outbound buffering (and size limits) from mqtt #2

Open
wants to merge 5 commits into
base: master
Choose a base branch
from

Commits on May 23, 2011

  1. NoCopy writes for all outbound mqtt messages.

    No longer hard limited to <128 byte messages.  Outbound messages are now only
    limited by the user's RAM size, (they provide the pointer) rather than by an
    internal library buffer.
    
    Receive messages are still limited to the library buffer, but changing the
    single #define is now sufficient to change the allowed size.
    
    Headers were updated to provide better code assistance in IDEs.
    
    Work by ReMake Electric, happily returned to the community.
    karlp committed May 23, 2011
    Copy the full SHA
    4ec2ef9 View commit details
    Browse the repository at this point in the history
  2. Removing the #ifdef option for outbound buffering.

    No need to ever use this, so don't keep it around #deffed out.
    karlp committed May 23, 2011
    Copy the full SHA
    7dfb29e View commit details
    Browse the repository at this point in the history
  3. Copy the full SHA
    bfa4590 View commit details
    Browse the repository at this point in the history

Commits on May 30, 2011

  1. Use consistent return codes in PubSubClient.

    Some methods previously returned 0 for success, (and for failure) and some returned 1 for success and 0 for failure.  Make them all use 0 for success, and different error codes for each failure, and make them proper defines.
    
    This is BACKWARDS INCOMPATIBLE unfortunately :(
    
    Calls that were
       while (client.connect(config.devicename) != 1)
    Should now be
       while ((rc = client.connect(config.devicename)) != ERR_OK)
    
    The old code used 1 for success, 0 for failure for:
       connect()
       loop()
    
    The old code used 0 for both success and failure for:
       publish()
    
    The old code used no return code at all for:
       subscribe()
    
    In all cases, the new code returns 0 (ERR_OK) for success, and either
    ERR_NOT_CONNECTED or ERR_TIMEOUT_EXCEEDED for the failure cases.  They are now
    also broken out per failure code.
    karlp committed May 30, 2011
    Copy the full SHA
    12f33c1 View commit details
    Browse the repository at this point in the history
  2. Copy the full SHA
    ff6c1a8 View commit details
    Browse the repository at this point in the history