Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enable ESP32 to use PubSubClient (make MQTT_CALLBACK_SIGNATURE functional) #336

Merged
merged 3 commits into from
Nov 2, 2018
Merged

Conversation

jaecktec
Copy link

#331

Added functional MQTT_CALLBACK_SIGNATURE to enable binding a object method to the callback handler.

@sidoh
Copy link

sidoh commented Dec 10, 2017

Can confirm that this works nicely on an ESP32. Thanks @jaecktec!

TD-er added a commit to TD-er/ESPEasy that referenced this pull request Feb 16, 2018
psy0rz pushed a commit to letscontrolit/ESPEasy that referenced this pull request Feb 16, 2018
* [issue #869] Added 'LWT' to last will topic and improved CPU load

See #869 for discussion on Last Will Topic.
Also changed the way it tried to reconnect to make it return a lot faster when connection is not (yet) possible and call the PubSubClient::loop() at a much slower pace to reduce CPU usage. (See #847)
This higher CPU load was probably introduced when fixing #683.

* [MQTT] Fix error reporting success status with longer payloads

Applied PR https://github.com/knolleary/pubsubclient/pull/360/files

* made MQTT_CALLBACK_SIGNATURE for esp32 functional

Applied PR knolleary/pubsubclient#336
@jaecktec jaecktec changed the title made MQTT_CALLBACK_SIGNATURE for esp32 functional Enable ESP32 to use PubSubClient (make MQTT_CALLBACK_SIGNATURE functional) Apr 24, 2018
@knolleary knolleary merged commit a29d0c3 into knolleary:master Nov 2, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants