feat: Use special version bumping rules for versions that start with 0.x (closes #37) #65
Conversation
|
Right, that tends to be how most projects seem to handle it. Technically with semantic versioning any 0.x.x version can contain breaking changes. However, most projects seem to track breaking changes by incrementing the minor number so there's still some indication. Then patch and minor get squashed into one component, effectively. |
src/semver.rs
Outdated
| @@ -53,6 +54,13 @@ impl Version { | |||
| }), | |||
| } | |||
| } | |||
|
|
|||
| /// Is the current version's major component 0? If so, rules are applied differently in `bump`. | |||
There was a problem hiding this comment.
What are thoughts on moving this comment to bump since it seems to be describing the behavior of bump and not is_0? It's possible we might use this in more than bump in the future.
Similarly, if bump is updated in the future (name change, does not use is_0, removed, etc.), the comment will no longer be valid.
There was a problem hiding this comment.
(I won't hold the PR up over this comment, but I do think it's worth considering)
There was a problem hiding this comment.
I added more detail to the documentation both to address your concern and answer Ben's question in code.
Required to use the auto-bumping feature of Dobby from conventional commits for a good chunk of our projects which are still 0.x (including Dobby!)