Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Query: add a defaultFields option #212

Open
1 task
joelmukuthu opened this issue Jan 31, 2019 · 3 comments
Open
1 task

Query: add a defaultFields option #212

joelmukuthu opened this issue Jan 31, 2019 · 3 comments

Comments

@joelmukuthu
Copy link
Collaborator

joelmukuthu commented Jan 31, 2019

OR make the default fields option to be false, such that users get to set default fields themselves via Model.options

  • remove Query.prototype.ensureFields

relates to #90

@privateOmega
Copy link
Contributor

@joelmukuthu I am working on this.

@joelmukuthu
Copy link
Collaborator Author

Hi @privateOmega, thank you for choosing to contribute! About this issue, I'm not yet sure which is the best direction to take, though I'm leaning more towards making false the default value for the fields option. Since that'll be a breaking change it might be slower to get released.

Would you like to take up #161 instead? It has a much bigger impact, is less controversial and should be less complicated to work on. Let me know if you'd like some help getting started!

PS: Sorry for not replying to your earlier email, I was sick and in bed, only recovering now.

@privateOmega
Copy link
Contributor

@joelmukuthu Sure. I will look into it. I've already partially worked on this concept by adding defaultFields. Hopefully we can revisit this at a later point of time.
It's alright, wishing you an immediate recovery.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants