make changes to cli #17
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
LGTM! |
tzilist
added a commit
to tzilist/crra
that referenced
this pull request
Jun 11, 2017
* 'master' of github.com:knowbody/crra: (25 commits) Correct build-source path (knowbody#18) v0.1.10 make changes to cli (knowbody#17) Update README.md v0.1.9 add chmod to build script (knowbody#14) v0.1.8 update permissions (knowbody#12) v0.1.7 Set file permissions on copy, and add README.md to template (knowbody#11) v0.1.6 add back webpack config v0.1.5 chenage permissions to copy.js v0.1.4 add scripts/copy.js back v0.1.3 fix bin in package.json v0.1.2 fix repo url ...
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This addresses #16
node 8's child_process is stricter about how arguments are passed in (see here). That said, I don't think
bin/build.jshas to be an executable/be spawnedCreating a new app is the same command (
create-reason-react-app myApp), so it should still work withyarn create. The CLI now defaults to creating anewapp, so we can add some other commands in here, like maybe deploy, etc.