prepare for 4.3.18 release

CONTRIBUTORS

@@ -178,6 +178,7 @@ Muffon
 Nathan King
 Nicolas Pinot
 Niels
+Niels Draaisma
 Nikita Belenkiy
 Niko Schmuck
 Norbert Sándor
@@ -196,6 +197,7 @@ Peter Keeler
 Peter N. Steinmetz
 Piotr Ladyzynski
 Piotr Ładyżyński
+Premek
 Premysl Vyhnal
 RadeK
 Radu

LICENSE

@@ -1,6 +1,6 @@
 The MIT License (MIT)
 
-Copyright 2015-2018 Knowm Inc. (http://knowm.org) and contributors.
+Copyright 2015-2019 Knowm Inc. (http://knowm.org) and contributors.
 Copyright 2012-2015 Xeiam LLC (http://xeiam.com) and contributors.
 
 Permission is hereby granted, free of charge, to any person obtaining a copy

README.md

@@ -101,17 +101,17 @@ Add the following dependencies in your pom.xml file. You will need at least xcha
     <dependency>
       <groupId>org.knowm.xchange</groupId>
       <artifactId>xchange-core</artifactId>
-      <version>4.3.17</version>
+      <version>4.3.18</version>
     </dependency>
     <dependency>
       <groupId>org.knowm.xchange</groupId>
       <artifactId>xchange-examples</artifactId>
-      <version>4.3.17</version>
+      <version>4.3.18</version>
     </dependency>
     <dependency>
       <groupId>org.knowm.xchange</groupId>
       <artifactId>xchange-XYZ</artifactId>
-      <version>4.3.17</version>
+      <version>4.3.18</version>
     </dependency>
 
 For snapshots, add the following repository to your pom.xml file.
@@ -124,7 +124,7 @@ For snapshots, add the following repository to your pom.xml file.
 
 The current snapshot version is: 
 
-    4.3.18-SNAPSHOT
+    4.3.19-SNAPSHOT
 
 ## Building with Maven
 

xchange-bitfinex/src/main/java/org/knowm/xchange/bitfinex/v1/BitfinexAdapters.java

@@ -480,7 +480,8 @@ public static OpenOrders adaptOrders(BitfinexOrderStatusResponse[] activeOrders)
             limitOrder = limitOrderCreator.get();
             break;
           default:
-            log.warn("Unhandled Bitfinex order type [{}]. Defaulting to limit order", order.getType());
+            log.warn(
+                "Unhandled Bitfinex order type [{}]. Defaulting to limit order", order.getType());
             limitOrder = limitOrderCreator.get();
             break;
         }
@@ -501,9 +502,10 @@ public static OpenOrders adaptOrders(BitfinexOrderStatusResponse[] activeOrders)
 
   private static void stopLimitWarning() {
     if (warnedStopLimit.compareAndSet(false, true)) {
-      log.warn("Found a stop-limit order. Bitfinex v1 API does not return limit prices for stop-limit "
-          + "orders so these are returned as stop-at-market orders. This warning will only appear "
-          + "once.");
+      log.warn(
+          "Found a stop-limit order. Bitfinex v1 API does not return limit prices for stop-limit "
+              + "orders so these are returned as stop-at-market orders. This warning will only appear "
+              + "once.");
     }
   }
 

xchange-coinmate/src/main/java/org/knowm/xchange/coinmate/CoinmateUtils.java

@@ -42,6 +42,6 @@ public static String getPair(CurrencyPair currencyPair) {
   }
 
   public static CurrencyPair getPair(String currencyPair) {
-    return new CurrencyPair(currencyPair.replace("_","/"));
+    return new CurrencyPair(currencyPair.replace("_", "/"));
   }
 }

xchange-cryptofacilities/src/main/java/org/knowm/xchange/cryptofacilities/dto/trade/BatchStatus.java

@@ -54,7 +54,7 @@ public static enum OrderStatus {
     clientOrderIdTooLong, // the client id is longer than the permissible limit
     maxPositionViolation, // not documented
     outsidePriceCollar, // the limit order crosses the spread but is an order of magnitude away from
-                        // the mark price - fat finger control
+    // the mark price - fat finger control
     postWouldExecute, // the post-only order would be filled upon placement, thus is cancelled
     iocWouldNotExecute, // the immediate-or-cancel order would not call
 

xchange-examples/src/main/java/org/knowm/xchange/examples/dsx/DSXExamplesUtils.java

@@ -4,12 +4,12 @@
 import org.knowm.xchange.Exchange;
 import org.knowm.xchange.ExchangeFactory;
 import org.knowm.xchange.ExchangeSpecification;
-import org.knowm.xchange.dsx.DSXExchange;
 
 /** @author Mikhail Wall */
 public class DSXExamplesUtils {
 
-  public static Exchange createExchange(Class<? extends Exchange> exchangeClass) throws IOException {
+  public static Exchange createExchange(Class<? extends Exchange> exchangeClass)
+      throws IOException {
 
     ExchangeSpecification exSpec = new ExchangeSpecification(exchangeClass);
     exSpec.setSecretKey("6FY66EC0YJ7YL4OHAC1X5ZEYAUUFRJBFI21I9S7A5PW7");

xchange-examples/src/main/java/org/knowm/xchange/examples/dsx/account/DSXAccountInfoDemoV3.java

@@ -1,5 +1,7 @@
 package org.knowm.xchange.examples.dsx.account;
 
+import java.io.IOException;
+import java.math.BigDecimal;
 import org.knowm.xchange.Exchange;
 import org.knowm.xchange.currency.Currency;
 import org.knowm.xchange.dsx.DSXExchangeV3;
@@ -9,9 +11,6 @@
 import org.knowm.xchange.examples.dsx.DSXExamplesUtils;
 import org.knowm.xchange.service.account.AccountService;
 
-import java.io.IOException;
-import java.math.BigDecimal;
-
 /** @author Pavel Chertalev */
 public class DSXAccountInfoDemoV3 {
 

xchange-examples/src/main/java/org/knowm/xchange/examples/dsx/marketdata/DSXDepthDemo.java

@@ -40,8 +40,7 @@ private static void generic(Exchange exchange) throws IOException {
 
   private static void raw(Exchange exchange) throws IOException {
 
-    DSXMarketDataService marketDataService =
-        (DSXMarketDataService) exchange.getMarketDataService();
+    DSXMarketDataService marketDataService = (DSXMarketDataService) exchange.getMarketDataService();
 
     Map<String, DSXOrderbook> depth =
         marketDataService.getDSXOrderbook("ltcusd", "LIVE").getOrderbookMap();

xchange-examples/src/main/java/org/knowm/xchange/examples/dsx/marketdata/DSXDepthDemoV3.java

@@ -1,5 +1,7 @@
 package org.knowm.xchange.examples.dsx.marketdata;
 
+import java.io.IOException;
+import java.util.Map;
 import org.knowm.xchange.Exchange;
 import org.knowm.xchange.ExchangeFactory;
 import org.knowm.xchange.currency.CurrencyPair;
@@ -9,9 +11,6 @@
 import org.knowm.xchange.dto.marketdata.OrderBook;
 import org.knowm.xchange.service.marketdata.MarketDataService;
 
-import java.io.IOException;
-import java.util.Map;
-
 /** @author Pavel Chertalev */
 public class DSXDepthDemoV3 {
 

xchange-examples/src/main/java/org/knowm/xchange/examples/dsx/marketdata/DSXTickerDemo.java

@@ -39,8 +39,7 @@ private static void generic(Exchange exchange) throws IOException {
 
   private static void raw(Exchange exchange) throws IOException {
 
-    DSXMarketDataService marketDataService =
-        (DSXMarketDataService) exchange.getMarketDataService();
+    DSXMarketDataService marketDataService = (DSXMarketDataService) exchange.getMarketDataService();
 
     DSXTickerWrapper ticker = marketDataService.getDSXTicker("btcusd", "LIVE");
     System.out.println(ticker.toString());

xchange-examples/src/main/java/org/knowm/xchange/examples/dsx/marketdata/DSXTickerDemoV3.java

@@ -1,5 +1,6 @@
 package org.knowm.xchange.examples.dsx.marketdata;
 
+import java.io.IOException;
 import org.knowm.xchange.Exchange;
 import org.knowm.xchange.ExchangeFactory;
 import org.knowm.xchange.currency.CurrencyPair;
@@ -10,8 +11,6 @@
 import org.knowm.xchange.service.marketdata.MarketDataService;
 import org.knowm.xchange.utils.CertHelper;
 
-import java.io.IOException;
-
 /** @author Mikhail Wall */
 public class DSXTickerDemoV3 {
 

xchange-examples/src/main/java/org/knowm/xchange/examples/dsx/marketdata/DSXTradesDemo.java

@@ -32,8 +32,7 @@ private static void generic(Exchange exchange) throws IOException {
 
   private static void raw(Exchange exchange) throws IOException {
 
-    DSXMarketDataService marketDataService =
-        (DSXMarketDataService) exchange.getMarketDataService();
+    DSXMarketDataService marketDataService = (DSXMarketDataService) exchange.getMarketDataService();
 
     Map<String, DSXTrade[]> trades =
         marketDataService.getDSXTrades("btcusd", 7, "LIVE").getTradesMap();

xchange-examples/src/main/java/org/knowm/xchange/examples/dsx/marketdata/DSXTradesDemoV3.java

@@ -1,5 +1,7 @@
 package org.knowm.xchange.examples.dsx.marketdata;
 
+import java.io.IOException;
+import java.util.Map;
 import org.knowm.xchange.Exchange;
 import org.knowm.xchange.ExchangeFactory;
 import org.knowm.xchange.currency.CurrencyPair;
@@ -9,9 +11,6 @@
 import org.knowm.xchange.dto.marketdata.Trades;
 import org.knowm.xchange.service.marketdata.MarketDataService;
 
-import java.io.IOException;
-import java.util.Map;
-
 /** @author Mikhail Wall */
 public class DSXTradesDemoV3 {
 

xchange-examples/src/main/java/org/knowm/xchange/examples/dsx/meta/DSXMetaDataDemoV3.java

@@ -1,5 +1,7 @@
 package org.knowm.xchange.examples.dsx.meta;
 
+import java.io.IOException;
+import java.math.BigDecimal;
 import org.knowm.xchange.Exchange;
 import org.knowm.xchange.currency.CurrencyPair;
 import org.knowm.xchange.dsx.DSXExchangeV3;
@@ -11,9 +13,6 @@
 import org.knowm.xchange.dto.trade.MarketOrder;
 import org.knowm.xchange.examples.dsx.DSXExamplesUtils;
 
-import java.io.IOException;
-import java.math.BigDecimal;
-
 /** @author Mikhail Wall */
 public class DSXMetaDataDemoV3 {
 

xchange-examples/src/main/java/org/knowm/xchange/examples/dsx/trade/DSXTradeDemoV3.java

@@ -1,5 +1,9 @@
 package org.knowm.xchange.examples.dsx.trade;
 
+import java.io.IOException;
+import java.math.BigDecimal;
+import java.util.Date;
+import java.util.Map;
 import org.knowm.xchange.Exchange;
 import org.knowm.xchange.currency.CurrencyPair;
 import org.knowm.xchange.dsx.DSXExchangeV3;
@@ -14,11 +18,6 @@
 import org.knowm.xchange.exceptions.ExchangeException;
 import org.knowm.xchange.service.trade.TradeService;
 
-import java.io.IOException;
-import java.math.BigDecimal;
-import java.util.Date;
-import java.util.Map;
-
 /** @author Mikhail Wall */
 public class DSXTradeDemoV3 {
 

xchange-examples/src/main/java/org/knowm/xchange/examples/dsx/trade/DSXUserTradeHistoryDemoV3.java

@@ -1,5 +1,7 @@
 package org.knowm.xchange.examples.dsx.trade;
 
+import java.io.IOException;
+import java.util.Map;
 import org.knowm.xchange.Exchange;
 import org.knowm.xchange.currency.CurrencyPair;
 import org.knowm.xchange.dsx.DSXExchangeV3;
@@ -11,9 +13,6 @@
 import org.knowm.xchange.exceptions.ExchangeException;
 import org.knowm.xchange.service.trade.TradeService;
 
-import java.io.IOException;
-import java.util.Map;
-
 /** @author Mikhail Wall */
 public class DSXUserTradeHistoryDemoV3 {
 

xchange-examples/src/main/java/org/knowm/xchange/examples/dsx/trade/DSXUserTransHistoryDemoV3.java

@@ -1,5 +1,7 @@
 package org.knowm.xchange.examples.dsx.trade;
 
+import java.io.IOException;
+import java.util.Map;
 import org.knowm.xchange.Exchange;
 import org.knowm.xchange.dsx.DSXExchangeV3;
 import org.knowm.xchange.dsx.dto.trade.DSXOrder;
@@ -9,9 +11,6 @@
 import org.knowm.xchange.examples.dsx.DSXExamplesUtils;
 import org.knowm.xchange.exceptions.ExchangeException;
 
-import java.io.IOException;
-import java.util.Map;
-
 /** @author Mikhail Wall */
 public class DSXUserTransHistoryDemoV3 {
 

xchange-itbit/src/main/java/org/knowm/xchange/itbit/ItBit.java

@@ -7,7 +7,6 @@
 import javax.ws.rs.Produces;
 import javax.ws.rs.QueryParam;
 import javax.ws.rs.core.MediaType;
-
 import org.knowm.xchange.itbit.dto.ItBitException;
 import org.knowm.xchange.itbit.dto.marketdata.ItBitDepth;
 import org.knowm.xchange.itbit.dto.marketdata.ItBitTrades;

xchange-itbit/src/main/java/org/knowm/xchange/itbit/ItBitAdapters.java

@@ -35,12 +35,12 @@
 import org.knowm.xchange.itbit.dto.ItBitFunding;
 import org.knowm.xchange.itbit.dto.account.ItBitAccountBalance;
 import org.knowm.xchange.itbit.dto.account.ItBitAccountInfoReturn;
-import org.knowm.xchange.itbit.dto.trade.ItBitOrder;
-import org.knowm.xchange.itbit.dto.trade.ItBitTradeHistory;
-import org.knowm.xchange.itbit.dto.trade.ItBitUserTrade;
 import org.knowm.xchange.itbit.dto.marketdata.ItBitTicker;
 import org.knowm.xchange.itbit.dto.marketdata.ItBitTrade;
 import org.knowm.xchange.itbit.dto.marketdata.ItBitTrades;
+import org.knowm.xchange.itbit.dto.trade.ItBitOrder;
+import org.knowm.xchange.itbit.dto.trade.ItBitTradeHistory;
+import org.knowm.xchange.itbit.dto.trade.ItBitUserTrade;
 import org.knowm.xchange.utils.DateUtils;
 
 public final class ItBitAdapters {

xchange-itbit/src/main/java/org/knowm/xchange/itbit/ItBitAuthenticated.java

@@ -13,18 +13,17 @@
 import javax.ws.rs.Produces;
 import javax.ws.rs.QueryParam;
 import javax.ws.rs.core.MediaType;
-
 import org.knowm.xchange.itbit.dto.ItBitException;
 import org.knowm.xchange.itbit.dto.ItBitFundingHistoryResponse;
-import org.knowm.xchange.itbit.dto.trade.ItBitOrder;
-import org.knowm.xchange.itbit.dto.trade.ItBitPlaceOrderRequest;
-import org.knowm.xchange.itbit.dto.trade.ItBitTradeHistory;
 import org.knowm.xchange.itbit.dto.account.ItBitAccountInfoReturn;
 import org.knowm.xchange.itbit.dto.account.ItBitDepositRequest;
 import org.knowm.xchange.itbit.dto.account.ItBitDepositResponse;
 import org.knowm.xchange.itbit.dto.account.ItBitWithdrawalRequest;
 import org.knowm.xchange.itbit.dto.account.ItBitWithdrawalResponse;
 import org.knowm.xchange.itbit.dto.marketdata.ItBitTicker;
+import org.knowm.xchange.itbit.dto.trade.ItBitOrder;
+import org.knowm.xchange.itbit.dto.trade.ItBitPlaceOrderRequest;
+import org.knowm.xchange.itbit.dto.trade.ItBitTradeHistory;
 import si.mazi.rescu.ParamsDigest;
 import si.mazi.rescu.SynchronizedValueFactory;
 

xchange-kucoin/src/main/java/org/knowm/xchange/kucoin/service/SymbolAPI.java

@@ -29,8 +29,7 @@ public interface SymbolAPI {
   KucoinResponse<List<SymbolResponse>> getSymbols() throws IOException;
 
   /**
-   * Ticker include only the inside (i.e. best) bid and ask data , last price and
-   * last trade size.
+   * Ticker include only the inside (i.e. best) bid and ask data , last price and last trade size.
    *
    * @param symbol The currency
    * @return The ticker.