Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update Coinbase Api to use the new Coinbase Exchange api V2 #1205

Closed
SeanRobb opened this issue Mar 8, 2016 · 15 comments
Closed

Update Coinbase Api to use the new Coinbase Exchange api V2 #1205

SeanRobb opened this issue Mar 8, 2016 · 15 comments

Comments

@SeanRobb
Copy link

SeanRobb commented Mar 8, 2016

Currently for Coinbase the V1 api is being used which is not set up for the Coinbase exchange. The new exchange api information is https://docs.exchange.coinbase.com/ . To utilize the Coinbase exchange via this library the update to use the V2 Coinbase exchange is required.

@soks86
Copy link

soks86 commented Jun 6, 2016

The new exchange is now named GDAX. API information is at https://docs.gdax.com/.

I'm in the middle of implementing updates to this and am going to commit a rename of Coinbaseex to Gdax unless someone suggests otherwise.

@timmolter
Copy link
Member

sounds good!

@DaveTheAve
Copy link

@soks86 It would be awesome if I could get access to your development build of the new GDax implementation. Would you mind committing it to a feature-branch? I would not mind providing any updates I personally require that may not already be implemented.

@brandonio21
Copy link

brandonio21 commented Sep 4, 2016

@soks86 - Any updates? I've started working on my own implementation and don't want to duplicate work. (I also don't have much clue what I'm doing.. I'm new to XChange .. Trying my best!)

Feature branch here: https://github.com/brandonio21/XChange/tree/gdax

@timmolter
Copy link
Member

@brandonio21 I haven't heard anything regarding updates on this implementation.

@brandonio21
Copy link

@timmolter - Okay, great. I've been working on it in my spare time and will submit a PR when ready :)

@timmolter
Copy link
Member

great!

@kennethjor
Copy link
Contributor

@brandonio21 @soks86 Can I be of help? I'd love to get GDAX support implemented.

@brandonio21
Copy link

@kennethjor I linked a feature branch above. Feel free to contribute to it or change what I've done. (I've been pretty busy lately).

I've pretty much just been stepping through The GDAX API Reference, using Coinbase as a reference. I haven't tested any of it yet and I'm sure some parts (like the JSON deserializing) could use some work. Looking forward to your contribution! :)

@Unbr8kbal
Copy link

@SeanRobb Do you still need this? and if so do you want it to go implement: https://docs.gdax.com/#api or https://developers.coinbase.com/api/v2 ??

@SeanRobb
Copy link
Author

Yes i would like it if the coinbase exchange endpoints were updated for the new v2 endpoints.

@tdiesler
Copy link
Contributor

tdiesler commented Dec 5, 2017

I'll take a stab at this, if that's ok.

tdiesler added a commit to tdiesler/XChange that referenced this issue Dec 6, 2017
@npomfret
Copy link
Contributor

npomfret commented Dec 6, 2017

@tdiesler it would be great if you could work on this. I've been meaning to do it for a while but have not had the time. Let me know if you get stuck.

I'm particularly interested in getting the deposit and withdrawal information. If you need help testing just shout!

#1728

tdiesler added a commit to tdiesler/XChange that referenced this issue Dec 7, 2017
@npomfret
Copy link
Contributor

I wonder if using this might be a quick win ?

@tdiesler
Copy link
Contributor

This project shows (very) low activity and has no releases.

You can monitor progress here. The functionality you're asking for is already implemented. This branch is still work in progress i.e. pls beware of incompatible changes.

tdiesler added a commit to tdiesler/XChange that referenced this issue Dec 18, 2017
timmolter added a commit that referenced this issue Dec 28, 2017
[resolves #1205] Update Coinbase Api to use the new Coinbase Exchange…
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

9 participants