Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add @JsonProperty to ExchangeSpecification #50

Closed
gary-rowe opened this issue Feb 9, 2013 · 7 comments
Closed

Add @JsonProperty to ExchangeSpecification #50

gary-rowe opened this issue Feb 9, 2013 · 7 comments
Assignees
@gary-rowe
Labels
Feature Request

Comments

@gary-rowe
Copy link
Collaborator

Adding these annotations will allow external applications to configure the ExchangeSpecification from JSON or YAML directly.
@ghost ghost assigned gary-rowe Feb 9, 2013
@gary-rowe
Copy link
Collaborator Author

Pushed directly to develop branch since it doesn't affect anything. Added some minor documentation fixes.

@timmolter
Copy link
Member

Is there a demo of this anywhere?

@gary-rowe
Copy link
Collaborator Author

Here: https://github.com/timmolter/XChange/blob/develop/xchange-core/src/main/java/com/xeiam/xchange/ExchangeSpecification.java

It's been through the release process.

@gary-rowe gary-rowe reopened this May 17, 2013
@gary-rowe
Copy link
Collaborator Author

Oops hit the wrong button. There's no external demo, but it's pretty obvious. I could knock one up if you like.

@timmolter
Copy link
Member

Ah, that's what those @JsonProperty annotations are for. Somehow I missed that.

An example would be good. It would make more people aware of this feature at least!

gary-rowe added a commit that referenced this issue May 19, 2013
@gary-rowe
#50 Added more detail to the documentation to provide a demo
9011173
@gary-rowe
Copy link
Collaborator Author

Added comments to ExchangeSpecification to provide a demo of use. Ready to close after code review.

@timmolter
Copy link
Member

Looks great! Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@gary-rowe gary-rowe

Labels
Feature Request
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@gary-rowe @timmolter