Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add ability to mark profiles as public #154

Closed
cdriehuys opened this issue Aug 11, 2017 · 4 comments
Closed

Add ability to mark profiles as public #154

cdriehuys opened this issue Aug 11, 2017 · 4 comments

Comments

@cdriehuys
Copy link
Member

Feature Proposal

As we discussed, it is easier from a user perspective to restrict access to specific profiles rather than on a per-user basis. To accomplish this, we would need to add a field to mark profiles as public, and a field to the Know Me user accessors that allows access to private profiles.

This will also allow us to remove the KMUserAccessor.can_read_everywhere field since the presence of an accessor implies read access to all public profiles.

@audsc
Copy link
Contributor

audsc commented Aug 14, 2017

Does adding apublic_profile boolean to the profile make sense to tackle this issue? @Brandogs

@Brandogs
Copy link
Contributor

lets make this field is_private

audsc added a commit that referenced this issue Aug 14, 2017
Closes #154
Remove can_read_everywhere field from KMUser
audsc added a commit that referenced this issue Aug 15, 2017
Closes #154
Remove can_read_everywhere field from KMUser
@audsc
Copy link
Contributor

audsc commented Aug 15, 2017

In our previous access model, from my understanding, all information about access was contained in the KMUserAccessor and ProfileAccessor. Adding this is_private field moves some of that information to the Profile model. Issue #157 further proposes that we remove the ProfileAccessor model, adding an is_admin field to KMUserAccessor. Is this what we want, or is it better to keep access information in separate models?

cdriehuys pushed a commit that referenced this issue Aug 16, 2017
@cdriehuys
Copy link
Member Author

Since KMUserAccessor holds access information for a specific user, it doesn't make sense for it to contain the private/public state of the profile since that applies to all access.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants