Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow profile items to have an attached list #68

Closed
cdriehuys opened this issue Jul 20, 2017 · 2 comments
Closed

Allow profile items to have an attached list #68

cdriehuys opened this issue Jul 20, 2017 · 2 comments
Assignees

Comments

@cdriehuys
Copy link
Member

Profile items should be able to have a list attached.

Implementation options

Text Field

We could store the list as a single text field, delimited by some character of our choosing. Client apps would pull the list, split it by the delimiter, and present it as a list. The save process would be similar: concatenate the list using the given delimiter and then give it to the backend as a single string.

The advantage of this approach is it's the simplest to deal with from the backend. However, we're very limited in terms of future expansion of list item functionality (ability to mark as important/done, link to from teamtalk, reorder, etc..).

Array Field

Since we use Postgres in production, we could store the list in an ArrayField. This would make reordering of list items easier, but does not address the rest of the concerns of the text field implementation. Additionally, the field is only available in Postgres, meaning we'd have to set up a local database for development.

Separate Model

We could create a separate ProfileListItem model. This model would be attached to a ProfileItem. While this approach requires creating a separate model, it is also the most extensible. We could easily add attributes to the model to extend the functionality of the list item.

@Brandogs
Copy link
Contributor

We have decided to use a separate model for profile list items. This will allow easier expansion of functionality in the future, as well as better integration with TeamTalk.

@cdriehuys
Copy link
Member Author

This isn't actually blocked seeing as profile items are not being renamed.

@cdriehuys cdriehuys removed the blocked label Jul 27, 2017
@cdriehuys cdriehuys self-assigned this Jul 27, 2017
cdriehuys added a commit that referenced this issue Aug 1, 2017
Add models to facilitate storing a list attached to a profile item.

Closes #68
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants