Add new folders in the main menu: "Newest", "Most viewed" and "Last chance" #55
Conversation
|
Maybe it's worth looking into this endpoint as well: http://www.arte.tv/hbbtvv2/services/web/index.php/EMAC/teasers/home/v2/fr There is a lot more information about the videos. The downside is that the lists are limited to 20 items. {
"teasers": {
"highlights": [...],
"playlists": [...],
"creative": [...],
"mostRecent": [...],
"mostViewed": [...],
"lastChance": [...]
}
} |
|
Hi @known-as-bmf, Thanks for the suggestion. I have modified the code to use this suggested API request. I don't think that limit of 20 items is a problem. The lists should just be convenient for the user of this plugin to scroll through and see, if there is an interesting video to watch. There is one problem though: The "mostRecent" section in the json contains only "Silex and the City" videos, but https://www.arte.tv/fr/videos/plus-recentes/ contains completely different videos. Maybe this is just a temporary flaw in the ARTE API. But if this is permanent, we cannot use this method. What do you think? |
|
The problem with the most recent videos seems to be resolved. What do you think about this PR? |
|
I think the "most recent" videos actually are "most recently uploaded file in the paltform" rather than "last aired program"... Is it really useful to browse this items ? |
|
I'm not certain about this, but it's indeed possible. When I tested it before, the listed videos (language of the plugin was set to For me, it would be very useful to be able to browse the most recent videos. When I open the plugin, I usually want to see what's new and not have to click through all these topic menus. I guess many other users would like this too. See #52 for a somehow related proposal. |
resources/lib/api.py
Outdated
| @@ -30,6 +31,11 @@ def magazines(lang): | |||
| return _load_json(url).get('magazines', {}) | |||
|
|
|||
|
|
|||
| def home_categories(name, lang): | |||
| url = _endpoints['home'].format(category_code='home', lang=lang) | |||
There was a problem hiding this comment.
category_code not needed
or you could refactor the _endpoints dict to merge similar paths (category & home) like so:
_endpoints = {
'categories': '/EMAC/teasers/{type}/v2/{lang}',
'category': '/EMAC/teasers/category/v2/{category_code}/{lang}',
'subcategory': '/OPA/v3/videos/subcategory/{sub_category_code}/page/1/limit/100/{lang}',
'magazines': '/OPA/v3/magazines/{lang}',
'collection': '/OPA/v3/videos/collection/{kind}/{collection_id}/{lang}',
'streams': '/OPA/v3/streams/{program_id}/{kind}/{lang}',
'daily': '/OPA/v3/programs/{date}/{lang}'
}and api functions like
def categories(lang):
url = _endpoints['categories'].format(type='categories', lang=lang)
return _load_json(url).get('categories', {})
def home_category(name, lang):
url = _endpoints['categories'].format(type='home', lang=lang)
return _load_json(url).get('teasers', {}).get(name, [])
resources/lib/view.py
Outdated
| categories = [mapper.map_categories_item( | ||
| item) for item in api.categories(lang)] | ||
| categories = [] | ||
| categories.append(mapper.create_newest_item()) |
There was a problem hiding this comment.
you can directly init category with the first menu items instead of using append
category = [
mapper.create_newest_item(),
mapper.create_most_viewed_item(),
mapper.create_last_chance_item()
]
|
@known-as-bmf Thanks for the review. I've implemented the requested code review changes. Let me know if I should squash the commits or if there is anything else to do. |
|
I squashed via the github pull-request merge :) Thanks for the contribution !! |
|
@known-as-bmf Thanks for merging this! Do you plan to make a new minor release soon, so that we can enjoy this feature? |
This PR adds three new folders to the main menu of the plugin: "Newest" (which contains a list of the most recent ARTE videos), "Most viewed" (which contains a list of the most viewed videos) and "Last chance" (which contains a list of videos that will soon be offline). So this PR allows the user of the plugin to browse through the ARTE videos in a more natural way.
Caveat: The API request does not return any deeper information about the videos, so there won't be any video description available for the videos in these three folders.