Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

emacs seem to return 0 #9

Closed
hansl opened this issue Mar 3, 2016 · 5 comments
Closed

emacs seem to return 0 #9

hansl opened this issue Mar 3, 2016 · 5 comments

Comments

@hansl
Copy link

hansl commented Mar 3, 2016

No description provided.

@knownasilya
Copy link
Owner

Not sure that is something I can help with 😸 Most likely it doesn't report it's width correctly. You could always set a default.

@hansl
Copy link
Author

hansl commented Mar 3, 2016

Worst case if you're about to return 0 you should return the default value passed in.

@knownasilya
Copy link
Owner

We do return the default if any of the other methods return 0.

@hansl
Copy link
Author

hansl commented Mar 3, 2016

index.js line 41 don't return the default value if it's 0. I'm not 100% sure what emacs return here, but it's the only case where I can see it returning 0.

@knownasilya
Copy link
Owner

True, but CLI_WIDTH is not a standard thing that anyone is setting, that is an option I added to override the default via envs. Would take a PR to use the default if that is 0.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants