-
-
Notifications
You must be signed in to change notification settings - Fork 52
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Migrate away from old style shims #79
Comments
wanted to get feed back before issuing a PR. |
I'm for that. In general I use the defaults. |
…nd reverting to the standard syntax with destructuing. Closes knownasilya#79
@webark I'd really prefer to keep using shims. We should switch them out for the new ones when they drop. |
hmm.. ok. This is just the only addon in my project that is using them and throwing the deprecation warning. |
I just don't think we should migrate backwards away from shims, when the point of migrating to shims was to be ready for module unification. |
ya. the only issue with switching them to the new ones when they land, which is looks like it will be in beta for 2.15, is that, and just quoting the meeting notes,
which makes sense if I'm reading it right. https://github.com/emberjs/core-notes/blob/master/ember-cli/2017-06/june-15.md |
though longterm it looks like, at least ones the moudle api lands, then will want addon devs to be using the new shims/module syntax https://github.com/emberjs/rfcs/blob/master/text/0176-javascript-module-api.md#addons |
@webark we definitely want to use the modules when they drop. I'm okay with temporarily moving back I suppose, but we'll need to move back to modules again soon. |
https://github.com/netguru/eslint-plugin-ember/blob/master/docs/rules/no-old-shims.md looks like that rule can be used with |
ya, i can look into that today. |
…-babel 6.6 rather then a beta version of the shims Closes knownasilya#79
…-babel 6.6 rather then a beta version of the shims Closes knownasilya#79
…-babel 6.6 rather then a beta version of the shims Closes knownasilya#79
I recently upgraded to the ember shims beta that uses the new module import syntax, and was getting deprication errors due to the use of things like
import Component from 'ember-component';
I suggest that we switch to using the default global Ember import, and then we could possibly do the constant destructuring. What are you're thoughts @knownasilya @rwwagner90 ?
The text was updated successfully, but these errors were encountered: