-
-
Notifications
You must be signed in to change notification settings - Fork 52
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
x-toggle
toggles on click when the onToggle
action does not update the value
#91
Comments
I've just tried |
…tion does not update the value
Just ran into this as well. |
are you sure this is a bug? If you did a standard checkbox input, and set up a one way binding with it, the check box would trigger but if you didn't update the value, it wouldn't update.. having it not update, you'd have resetup two way binding. Right? |
@webark, the With Ember, the primary source of truth is a property that you pass as Also, If the app decides not to change @knownasilya Are we on the same page? |
I think I have a failing test for this in #94 |
…tion does not update the value - panning should not enable when the action does not update the value
How to reproduce
Now click the toggle.
What I expect to happen
The component should not toggle because the action does not update the value.
What actually happens
The component does toggle, the value and the component's state are out of sync.
Reproduction
https://ember-twiddle.com/85bcda587638b642fcf254d550488899?numColumns=2&openFiles=controllers.application.js%2Ctemplates.application.hbs
Notes
Happens only for clicking. Dragging works correctly: the component toggles only when the action updates the value.
The text was updated successfully, but these errors were encountered: