Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fixes deprecation warning in ember-cli 2.12 #36

Merged
merged 1 commit into from
Apr 5, 2017
Merged

Fixes deprecation warning in ember-cli 2.12 #36

merged 1 commit into from
Apr 5, 2017

Conversation

jpadilla
Copy link
Contributor

@jpadilla jpadilla commented Apr 5, 2017 

DEPRECATION: Addon files were detected in `/Users/jpadilla/Projects/Alias/gasolinamovil/admin/node_modules/pagination-pager/addon`, but no JavaScript preprocessors were found for `pagination-pager`. Please make sure to add a preprocessor (most likely `ember-cli-babel`) to in `dependencies` (NOT `devDependencies`) in `pagination-pager`'s `package.json`.

@knownasilya
Copy link
Owner

Looks like the change doesn't sit well with the outdated ember-cli version.

@knownasilya knownasilya self-requested a review April 5, 2017 19:58
@knownasilya knownasilya self-assigned this Apr 5, 2017
@jpadilla
Copy link
Contributor Author

jpadilla commented Apr 5, 2017

@knownasilya perhaps use an older version of ember-cli-babel?

@knownasilya
Copy link
Owner

Never mind, it's the old node version in travis

@knownasilya knownasilya merged commit 28b276b into knownasilya:master Apr 5, 2017
@jpadilla
Copy link
Contributor Author

jpadilla commented Apr 5, 2017

@knownasilya thanks!

@jpadilla jpadilla mentioned this pull request Apr 5, 2017
Closed
knownasilya pushed a commit that referenced this pull request Apr 5, 2017
v2.4.3
7e5c1c3 
- Fix babel deprecation error, see #35 and #36
- Update bootstrap syntax, see #34
- Update travis node version
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@knownasilya knownasilya knownasilya approved these changes

Assignees

@knownasilya knownasilya

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@jpadilla @knownasilya