Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Column with Incremental Run Length Encoding #8

Merged
merged 16 commits into from Mar 11, 2022

Conversation

monsterkrampe
Copy link
Member

closes #1

This PR adds a Column implementation with incremental run length encoding. It also implements a fitting ColumnScan and ColumnBuilder.
Also, the AdaptiveColumnBuilder is adjusted to use the RleColumn instead of the VectorColumn when the use of the latter would take significantly more memory (based on a heuristic).

@monsterkrampe monsterkrampe requested a review from mmarx March 7, 2022 09:09
@monsterkrampe monsterkrampe requested review from ellmau and mmarx and removed request for mmarx and ellmau March 7, 2022 09:18
Copy link
Member

@ellmau ellmau left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Casually glanced over the code (due to vacation).

I think @mmarx shall still look into it as well.

src/physical/columns/adaptive_column_builder.rs Outdated Show resolved Hide resolved
src/physical/columns/adaptive_column_builder.rs Outdated Show resolved Hide resolved
src/physical/columns/column.rs Show resolved Hide resolved
src/physical/columns/rle_column.rs Show resolved Hide resolved
src/physical/columns/rle_column.rs Outdated Show resolved Hide resolved
@monsterkrampe
Copy link
Member Author

Thanks for your comments, I'm going to work through them :)

src/physical/columns/adaptive_column_builder.rs Outdated Show resolved Hide resolved
src/physical/columns/adaptive_column_builder.rs Outdated Show resolved Hide resolved
src/physical/columns/rle_column.rs Outdated Show resolved Hide resolved
src/physical/columns/rle_column.rs Outdated Show resolved Hide resolved
src/physical/columns/rle_column.rs Outdated Show resolved Hide resolved
src/physical/columns/rle_column.rs Outdated Show resolved Hide resolved
src/physical/columns/rle_column.rs Outdated Show resolved Hide resolved
@monsterkrampe monsterkrampe requested a review from mmarx March 9, 2022 07:33
@ellmau

This comment was marked as outdated.

@ellmau ellmau mentioned this pull request Mar 9, 2022
Copy link
Member

@mmarx mmarx left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Once we have decided whether we want to refactor AdaptiveColumnBuilder now or later, this can be merged (at least if we decide for later).

@monsterkrampe monsterkrampe merged commit 1ec1789 into main Mar 11, 2022
@monsterkrampe monsterkrampe deleted the feature/issue-1-column-rle branch March 11, 2022 15:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Support incremental RLE
3 participants