Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

42 Upgrade Credential Adapter Version To v1.3.28 #43

Merged
merged 1 commit into from May 10, 2022
Merged

42 Upgrade Credential Adapter Version To v1.3.28 #43

merged 1 commit into from May 10, 2022

Conversation

LuisOsta
Copy link
Contributor

No description provided.

@LuisOsta LuisOsta added the enhancement New feature or request label May 10, 2022
@LuisOsta LuisOsta self-assigned this May 10, 2022
@LuisOsta LuisOsta linked an issue May 10, 2022 that may be closed by this pull request
Upgrade Credential Adapter Version To v1.3.28 #42
Closed
@LuisOsta LuisOsta requested a review from sKudryashov May 10, 2022 18:56
sKudryashov
sKudryashov approved these changes May 10, 2022
View reviewed changes
Copy link

@sKudryashov sKudryashov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just an advice, probably it makes sense to declare type VPProof map[string]interface{} but it is up to you

presentation/presentation.go Show resolved Hide resolved
service/credential_adapter/credential_adapter.go Show resolved Hide resolved
@LuisOsta LuisOsta merged commit 70ae49a into main May 10, 2022
@LuisOsta LuisOsta deleted the 42-upgrade-credential-adapter-version-to-v1328 branch May 10, 2022 19:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sKudryashov sKudryashov sKudryashov approved these changes

@adewaleafolabi adewaleafolabi Awaiting requested review from adewaleafolabi

Assignees

@LuisOsta LuisOsta

Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Upgrade Credential Adapter Version To v1.3.28
2 participants
@LuisOsta @sKudryashov