Remove not yet initialized logger usage and redundant os.Exit

knoxite · Dec 9, 2021 · 0dd39cd · 0dd39cd
1 parent acca8e5
commit 0dd39cd
Show file tree

Hide file tree

Showing 2 changed files with 3 additions and 4 deletions.
diff --git a/cmd/knoxite/logger.go b/cmd/knoxite/logger.go
@@ -35,12 +35,10 @@ func (l *Logger) WithWriter(w io.Writer) *Logger {
 
 func (l Logger) Fatal(v ...interface{}) {
 	l.log(knoxite.LogLevelFatal, v...)
-	os.Exit(1)
 }
 
 func (l Logger) Fatalf(format string, v ...interface{}) {
 	l.logf(knoxite.LogLevelFatal, format, v...)
-	os.Exit(1)
 }
 
 func (l Logger) Warn(v ...interface{}) {

diff --git a/cmd/knoxite/main.go b/cmd/knoxite/main.go
@@ -10,12 +10,13 @@
 package main
 
 import (
+	"fmt"
 	"os"
 	"syscall"
 
 	shutdown "github.com/klauspost/shutdown2"
-	"github.com/spf13/cobra"
 	"github.com/rsteube/carapace"
+	"github.com/spf13/cobra"
 
 	"github.com/knoxite/knoxite"
 	"github.com/knoxite/knoxite/cmd/knoxite/config"
@@ -84,7 +85,7 @@ func main() {
 	carapace.Gen(RootCmd)
 
 	if err := RootCmd.Execute(); err != nil {
-		log.Fatal(err)
+		fmt.Println(err)
 		os.Exit(-1)
 	}
 }