-
Notifications
You must be signed in to change notification settings - Fork 27
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Tests for repository passwd #128
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just some minor nitpicks due to a typo. Thanks for your contribution!
repository_test.go
Outdated
|
||
func TestRepositoryChangePassword(t *testing.T) { | ||
testPassword := "this_is_a_password" | ||
newPassowrd := "this_is_another_password" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Typo in variable name: newPassword
@penguwin thank you for reviewing! |
|
||
dir, err := ioutil.TempDir("", "knoxite") | ||
if err != nil { | ||
t.Errorf("Failed creating temporary dir for repository: %s", err) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Instead of a t.Errorf
followed by a return, I would suggest using t.Fatalf
throughout this change.
Closes #117