Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix Mega tests #133

Merged
merged 2 commits into from
Jul 31, 2020
Merged

Fix Mega tests #133

merged 2 commits into from
Jul 31, 2020

Conversation

ma-hartma
Copy link
Member

Fix mega tests by using a copy of the data for the upload method of the mega library, which overrides the data instead of using a copy.
We could create a PR at github.com/t3rm1n4l/go-mega to fix this issue and remove our workaround after that.

@ma-hartma ma-hartma linked an issue Jul 30, 2020 that may be closed by this pull request
Copy link
Member

@penguwin penguwin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

storage/mega/mega.go Outdated Show resolved Hide resolved
storage/mega/mega.go Show resolved Hide resolved
Copy link
Member

@muesli muesli left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@penguwin penguwin merged commit 9312b52 into master Jul 31, 2020
@muesli muesli deleted the mega-tests branch August 10, 2020 23:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
First release
Awaiting triage
Development

Successfully merging this pull request may close these issues.

Tests for Mega storage backend
3 participants