Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

deps: updates all deps notably vtprotobuf and TinyGo #54

Merged
merged 1 commit into from
Jun 25, 2023

Conversation

codefromthecrypt
Copy link
Collaborator

Issue #, if available:

N/A

Description of changes:

This updates to the latest TinyGo dropping the oldest (0.25.0) from the test matrix. It also updates vtprotobuf to the latest version which includes optimizations and bug fixes, visible in the generated source.

This also updates other dependencies that were out of date including workflow actions and wazero.

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

This updates to the latest TinyGo dropping the oldest (0.25.0) from the
test matrix. It also updates vtprotobuf to the latest version which
includes optimizations and bug fixes, visible in the generated source.

This also updates other dependencies that were out of date including
workflow actions and wazero.

Signed-off-by: Adrian Cole <adrian@tetrate.io>
Copy link
Collaborator Author

@codefromthecrypt codefromthecrypt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Highlighting some differences in generated output. Nothing is troubling.

if _, err := vtmsg.MarshalToVT(dAtA[i:]); err != nil {
return 0, err
}
size, err := vtmsg.MarshalToSizedBufferVT(dAtA[:i])
Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this is one optimization in vtprotobuf 0.4.0

MarshalToSizedBufferVT([]byte) (int, error)
}); ok {
size, err := marshalto.MarshalToSizedBufferVT(dAtA[:i])
size, err := vtmsg.MarshalToSizedBufferVT(dAtA[:i])
Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this is a polishing change from vtprotobuf 0.4.0

if m.unknownFields != nil {
n += len(m.unknownFields)
}
n += len(m.unknownFields)
Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this is a polishing change from vtprotobuf 0.4.0

@codefromthecrypt codefromthecrypt merged commit b72bd22 into main Jun 25, 2023
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant