feat: support multiple default values #203
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This CL supports multiple default values like <proxy=cfg1|cfg2|cfg3>, this parameter will rendered like this in `generateView`: ``` --proxy=cfg1|cfg2|cfg3---------------------------------- |cfg1 | |cfg2 | |cfg3 | |------------------------------------------------------ ``` then we can use up/down arrow to select the wanted item, after press `enter` evaluateResult will be executed. This CL also let the parameter view's title use larger width. close knqyf263#192
|
@knqyf263 Please review this PR. Thanks. |
|
@knqyf263 Hi, could you take a little time to review this PR? I think this PR will solve the issue that some people encountered and suggested. |
|
@hitzhangjie Thanks for the PR! Will check this out! Really like the idea |
|
@hitzhangjie Interested in amending your PR to support the variable character proposal here #247 (comment)? 😁 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This CL supports multiple default values like <proxy=cfg1|cfg2|cfg3>,
this parameter will rendered like this in
generateView:then we can use up/down arrow to select the wanted item, after press
enterevaluateResult will be executed.This CL also let the parameter view's title use larger width.
close #192