Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move *.spec.js in src/ to test/ #35

Closed
serv opened this issue Dec 5, 2014 · 3 comments
Closed

Move *.spec.js in src/ to test/ #35

serv opened this issue Dec 5, 2014 · 3 comments

Comments

@serv
Copy link

serv commented Dec 5, 2014

I think the repo will look more organized, if we moved *.spec.js in src/ to test/.
For example, angular.js does this.

@cerdman
Copy link

cerdman commented Dec 5, 2014

@serv - as someone running an [angularjs enterprise scale] app, I find it much easier to keep the *.spec.js next to the components when dealing with a complex structure. See yeoman/generator-angular#109 . When you need to mirror directory structure and copy/paste to specs or use a generator of any sort - it just no longer is practical.

@serv
Copy link
Author

serv commented Dec 5, 2014

I wanted to point out that most repositories will try to segregate tests from the source code in some way and that putting them in the same folder is an oddity. My suggestion is that we follow the convention and segregate the source code and tests.

Some examples are jquery, backbone.

If we continue to go the route of keeping tests in src/, we should check out how ember does it. The source file is divided up into packages and each package contains tests.

@knsv
Copy link
Collaborator

knsv commented Dec 8, 2014

The reason for having the tests in the same folder is simply that it is convenient to have them next to the source.

It is important to keep the repos organized so I thank you for your input but lets keep them there for now. I will however take a look at how ember for some inspiration.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants