Default style when using the CLI #205
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -109,6 +109,8 @@ cli.prototype.parse = function(argv, next) { | |||
| } catch (err) { | |||
| this.errors.push(err) | |||
| } | |||
| } else { | |||
| options.css = fs.readFileSync(__dirname + '/../dist/mermaid.css') | |||
There was a problem hiding this comment.
would prefer this use node's path.join to ensure it remains cross-platform safe. you'll need to var path = require('path') at the top of the file, and then this line becomes:
options.css = fs.readFileSync(path.join(__dirname, '..', 'dist', 'mermaid.css'))
|
one comment, but otherwise 👍—thanks so much for putting this together, and for writing up tests! |
|
Great! |
mgenereu
pushed a commit
to mgenereu/mermaid
that referenced
this pull request
Jun 25, 2022
…yarn/develop/mocha-9.0.0 Bump mocha from 8.4.0 to 9.0.0
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uses the default Mermaid style when no explicit style is set. Fixes #196
Added a test to prevent regressions and additionally set the width of the default style to "auto".
Honestly I have no idea if setting the width to "auto" would cause any issues, the previous 1200px just generated a weirdly small image on my system.
Before:
After:
