Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Trimming whitespace after participant id #882

Merged
merged 1 commit into from
Jul 14, 2019
Merged

Trimming whitespace after participant id #882

merged 1 commit into from
Jul 14, 2019

Conversation

IOrlandoni
Copy link
Member

Fixes issue #809 by trimming actor id.

@coveralls
Copy link

Pull Request Test Coverage Report for Build 835

  • 17 of 18 (94.44%) changed or added relevant lines in 1 file are covered.
  • 1 unchanged line in 1 file lost coverage.
  • Overall coverage increased (+0.05%) to 53.22%
Changes Missing Coverage Covered Lines Changed/Added Lines %
src/diagrams/sequence/parser/sequenceDiagram.js 17 18 94.44%
Files with Coverage Reduction New Missed Lines %
src/diagrams/sequence/parser/sequenceDiagram.js 1 67.92%
Totals Coverage Status
Change from base Build 834: 0.05%
Covered Lines: 2383
Relevant Lines: 4432
💛 - Coveralls

@knsv
Copy link
Collaborator

knsv commented Jul 14, 2019

Nice first pull request!

@knsv knsv merged commit 484b24d into mermaid-js:master Jul 14, 2019
@IOrlandoni IOrlandoni mentioned this pull request Jul 14, 2019
Closed
@IOrlandoni IOrlandoni deleted the fix/whitespace-in-participant branch July 15, 2019 01:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@IOrlandoni @coveralls @knsv