Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

@igorpeshansky I have tested the patch and wanted to bring to your attention a potential compatibility concern with Ruby versions lower than 2.7.0, despite the gemspec specifying a requirement of ">= 2.2". The error encountered during compilation in Ruby version 2.3.1 is as follows: #76

Closed
ABHIJITH-EA opened this issue Nov 14, 2023 · 0 comments

Comments

@ABHIJITH-EA
Copy link

          @igorpeshansky I have tested the patch and wanted to bring to your attention a potential compatibility concern with Ruby versions lower than 2.7.0, despite the gemspec specifying a requirement of ">= 2.2". The error encountered during compilation in Ruby version 2.3.1 is as follows:
compiling unf.cc
cc1plus: warning: command line option ‘-Wdeclaration-after-statement’ is valid for C/ObjC but not for C++ [enabled by default]
cc1plus: warning: command line option ‘-Wimplicit-function-declaration’ is valid for C/ObjC but not for C++ [enabled by default]
unf.cc:45:3: error: ‘rb_data_type_struct::<anonymous struct>’ has no non-static data member named ‘dcompact’
   };
   ^
make: *** [unf.o] Error 1

The "dcompact" member, which I believe was introduced in Ruby version 2.7.0, is the source of this issue. This patch appears to not fully resolve the issue introduced by #72

Originally posted by @ABHIJITH-EA in #75 (comment)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant