Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

identify not working with mpl 3.8 #13

Closed
zmoon opened this issue Sep 21, 2023 · 2 comments · Fixed by #24
Closed

identify not working with mpl 3.8 #13

zmoon opened this issue Sep 21, 2023 · 2 comments · Fixed by #24
Labels
bug Something isn't working documentation Improvements or additions to documentation

Comments

@zmoon
Copy link
Collaborator

zmoon commented Sep 21, 2023

Warning
tams.identify not working with Matplotlib 3.8.

The format of ContourSet.allsegs has changed. It seems there is now just one (path) array for all of the contours of a certain level (instead of a list containing an array for each contour). The recommendation appears to be to use .get_paths(). This has the codes as well, which we could use to extract the coordinates for each contour (like in modflowpy/flopy#1951). Or we could try to move to direct ContourPy usage.

Note

The current method should work in 3.8.1 (the previous behavior was restored), just have to avoid 3.8.0.

@zmoon zmoon added the bug Something isn't working label Sep 21, 2023
@zmoon zmoon changed the title mpl 3.8 identify not working with mpl 3.8 Sep 29, 2023
zmoon added a commit that referenced this issue Sep 29, 2023
@zmoon zmoon pinned this issue Oct 4, 2023
@zmoon

This comment was marked as duplicate.

@zmoon zmoon added the documentation Improvements or additions to documentation label Apr 9, 2024
@zmoon
Copy link
Collaborator Author

zmoon commented Apr 9, 2024

I think for now (this issue) we should just add relevant info about this to the docs section, and we can investigate using ContourPy later.

@zmoon zmoon mentioned this issue Apr 14, 2024
@zmoon zmoon closed this as completed in #24 May 21, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working documentation Improvements or additions to documentation
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant