Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Listen for websocket events instead of polling #21

Open
andyedinborough opened this issue May 18, 2021 · 0 comments
Open

Listen for websocket events instead of polling #21

andyedinborough opened this issue May 18, 2021 · 0 comments

Comments

@andyedinborough
Copy link
Collaborator

Polling is inefficient and slow. Instead, the Ryobi GDO API supports listening for events:

    public static String subscribeNotifications(String str) {
        return "{\"jsonrpc\":\"2.0\",\"method\":\"wskSubscribe\",\"params\":{\"topic\":\"" + str + ".wskAttributeUpdateNtfy\"}}";
    }

    public static String unsubscribeNotifications(String str) {
        return "{\"jsonrpc\":\"2.0\",\"method\":\"wskUnsubscribe\",\"params\":{\"topic\":\"" + str + ".wskAttributeUpdateNtfy\"}}";
    }

We should update the code to open the websocket on start and keep it open with periodic pings.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant