Skip to content

Commit

Permalink
Fix CI
Browse files Browse the repository at this point in the history
  • Loading branch information
shalvah committed Jul 16, 2022
1 parent 0f7de14 commit 185b327
Show file tree
Hide file tree
Showing 5 changed files with 8 additions and 6 deletions.
1 change: 0 additions & 1 deletion phpstan.neon
Original file line number Diff line number Diff line change
Expand Up @@ -14,7 +14,6 @@ parameters:
- '#Access to an undefined property Illuminate\\Contracts\\Foundation\\Application::\$view#'
- '#Unsafe usage of new static#'
- '#Dead catch#'
- '/Call to an undefined static method Illuminate\\Database\\Eloquent\\Model::first\(\)/'
- '/Call to an undefined method League\\Flysystem\\Filesystem::deleteDir\(\)./'
- '/Instantiated class League\\Flysystem\\Adapter\\Local not found./'
- '/Parameter #1 \$adapter of class League\\Flysystem\\Filesystem constructor expects League\\Flysystem\\FilesystemAdapter, League\\Flysystem\\Adapter\\Local given./'
Expand Down
2 changes: 1 addition & 1 deletion src/Extracting/UrlParamsNormalizer.php
Original file line number Diff line number Diff line change
Expand Up @@ -100,7 +100,7 @@ public static function normalizeParameterNamesInRouteUri(Route $route, Reflectio
*
* @param \Illuminate\Routing\Route $route
* @param string $paramName The name of the URL parameter
* @param array $typeHintedArguments Arguments to the method that have typehints
* @param array<string, Model> $typeHintedEloquentModels
* @param string|null $default Default field to use
*
* @return string|null
Expand Down
3 changes: 1 addition & 2 deletions tests/GenerateDocumentationTest.php
Original file line number Diff line number Diff line change
Expand Up @@ -398,8 +398,7 @@ public function will_not_overwrite_manually_modified_content_unless_force_flag_i
public function generates_correct_url_params_from_resource_routes_and_field_bindings()
{
if (version_compare($this->app->version(), '7.0.0', '<')) {
$this->markTestSkipped("Laravel < 7.x doesn't support field binding syntax.");

$this->markTestSkipped("Field binding syntax was introduced in Laravel 7.");
return;
}

Expand Down
3 changes: 1 addition & 2 deletions tests/Strategies/UrlParameters/GetFromLaravelAPITest.php
Original file line number Diff line number Diff line change
Expand Up @@ -105,8 +105,7 @@ public function __construct(array $parameters = [])
public function can_infer_data_from_field_bindings()
{
if (version_compare($this->app->version(), '7.0.0', '<')) {
$this->markTestSkipped("Laravel < 7.x doesn't support field binding syntax.");

$this->markTestSkipped("Field binding syntax was introduced in Laravel 7.");
return;
}

Expand Down
5 changes: 5 additions & 0 deletions tests/Unit/ExtractedEndpointDataTest.php
Original file line number Diff line number Diff line change
Expand Up @@ -41,6 +41,11 @@ public function normalizes_resource_url_params_from_underscores_to_hyphens()
/** @test */
public function normalizes_nonresource_url_params_with_inline_bindings()
{
if (version_compare($this->app->version(), '7.0.0', '<')) {
$this->markTestSkipped("Field binding syntax was introduced in Laravel 7.");
return;
}

Route::get('things/{thing:slug}', [TestController::class, 'show']);
$route = $this->getRoute(['prefixes' => '*']);

Expand Down

0 comments on commit 185b327

Please sign in to comment.