Support @apiResource with missing @apiResourceModel
#662
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
1 task
|
Can you add a test for the expected behaviour? You can look at the existing ApiResourceTests for an example. |
|
Hi, I've added tests but I'm not sure if I'm doing things correctly, because I don't have much experience for writing tests, so if I did something bad please correct me, ty. 🙂 |
shalvah
reviewed
May 28, 2023
shalvah
reviewed
May 28, 2023
shalvah
reviewed
May 28, 2023
|
Nice, thanks! |
shalvah
changed the title
@apiResource with missing @apiResourceModel
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Update：
This is a little feature to allow the document generate when the JsonResource is working with empty resource which means won't have any model to specify on the @apiResourceModel tag.
This might help some project using JsonResource to manage the api response which like webhook api or none data response api.
From #652.