Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

pin dependency versions #378

Closed
japaric opened this issue Feb 9, 2021 · 1 comment · Fixed by #384 or knurling-rs/probe-run#146
Closed

pin dependency versions #378

japaric opened this issue Feb 9, 2021 · 1 comment · Fixed by #384 or knurling-rs/probe-run#146
Labels
difficulty: easy Pretty easy to solve priority: high High priority for the Knurling team type: enhancement Enhancement or feature request
Milestone
v0.2.0

Comments

@japaric
Copy link
Member

japaric commented Feb 9, 2021 •
edited
Loading

all dependencies that are in this repo ('path' dependencies) and have the "unstable" feature (e.g. defmt-decoder) should be specified in Cargo.toml using an exact version, e.g. =0.1.2.
that way we'll be able to make breaking changes in the "unstable" API in patch versions

NOTE this also needs to be in probe-run
@japaric japaric added the priority: high High priority for the Knurling team label Feb 9, 2021
@japaric japaric added this to the v0.2.0 milestone Feb 9, 2021
@Urhengulas Urhengulas added difficulty: easy Pretty easy to solve type: enhancement Enhancement or feature request labels Feb 9, 2021
@Urhengulas Urhengulas mentioned this issue Feb 11, 2021
Merged
@bors bors bot closed this as completed in 2595cab Feb 11, 2021
@jonas-schievink
Copy link
Contributor

reopening, the probe-run changes are still outstanding

@Urhengulas Urhengulas mentioned this issue Feb 11, 2021
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
difficulty: easy Pretty easy to solve priority: high High priority for the Knurling team type: enhancement Enhancement or feature request
Projects
None yet
Milestone
v0.2.0
3 participants
@jonas-schievink @japaric @Urhengulas