Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

README.md: Document MSRV #447

Merged
merged 2 commits into from Apr 14, 2021
Merged

README.md: Document MSRV #447

merged 2 commits into from Apr 14, 2021

Conversation

Urhengulas
Copy link
Member

Fix #443

@Urhengulas Urhengulas requested a review from a team April 13, 2021 09:10
Copy link
Member

@japaric japaric left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good!

README.md Outdated
@@ -20,6 +20,10 @@ To include `defmt` in your existing project, follow our [Application Setup guide

[Application Setup guide]: https://defmt.ferrous-systems.com/setup-app.html

## MSRV
`defmt` always compiles on the [latest `stable` rust release](https://github.com/rust-lang/rust/releases/latest). This is enforced by our CI building and testing against this version. <br>
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nit: can we avoid the HTML element here?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yees, but then we either have two spaces, which is bad because it's hard to see, or a newline, but this actually appears differently in the rendered version. But in the end it probably doesn't matter.

@japaric
Copy link
Member

japaric commented Apr 14, 2021

feel free to address nit and send to bors or just send to bors directly
bors d+

@bors
Copy link
Contributor

bors bot commented Apr 14, 2021

✌️ Urhengulas can now approve this pull request. To approve and merge a pull request, simply reply with bors r+. More detailed instructions are available here.

@Urhengulas
Copy link
Member Author

bors r+

@bors
Copy link
Contributor

bors bot commented Apr 14, 2021

Build succeeded:

@bors bors bot merged commit 963152f into main Apr 14, 2021
@bors bors bot deleted the document-msrv branch April 14, 2021 14:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

MSRV
2 participants