New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
README.md
: Document MSRV
#447
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good!
README.md
Outdated
@@ -20,6 +20,10 @@ To include `defmt` in your existing project, follow our [Application Setup guide | |||
|
|||
[Application Setup guide]: https://defmt.ferrous-systems.com/setup-app.html | |||
|
|||
## MSRV | |||
`defmt` always compiles on the [latest `stable` rust release](https://github.com/rust-lang/rust/releases/latest). This is enforced by our CI building and testing against this version. <br> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
nit: can we avoid the HTML element here?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yees, but then we either have two spaces, which is bad because it's hard to see, or a newline, but this actually appears differently in the rendered version. But in the end it probably doesn't matter.
feel free to address nit and send to bors or just send to bors directly |
✌️ Urhengulas can now approve this pull request. To approve and merge a pull request, simply reply with |
bors r+ |
Build succeeded: |
Fix #443