Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Migration guide v0.2.x to v0.3.0 #547

Merged
merged 17 commits into from Oct 19, 2021
Merged

Migration guide v0.2.x to v0.3.0 #547

merged 17 commits into from Oct 19, 2021

Conversation

Urhengulas
Copy link
Member

@Urhengulas Urhengulas commented Jul 21, 2021 •
edited

@japaric japaric added this to the v0.3.0 milestone Aug 10, 2021
@Urhengulas Urhengulas removed their assignment Oct 11, 2021
@Urhengulas Urhengulas marked this pull request as ready for review October 14, 2021 08:46
japaric
japaric reviewed Oct 18, 2021
View reviewed changes
Copy link
Member

@japaric japaric left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Gave this a read and looks good. +1 to the other review comments

@japaric
Copy link
Member

japaric commented Oct 18, 2021

I have not yet checked your last commit but something that come to mind and that should be mentioned here (maybe?) is the change in the CLI of probe-run: we now have a --backtrace={always,never,auto} flag instead of several flags.

@Urhengulas
Copy link
Member Author

I have not yet checked your last commit but something that come to mind and that should be mentioned here (maybe?) is the change in the CLI of probe-run: we now have a --backtrace={always,never,auto} flag instead of several flags.

I will add that

japaric
japaric approved these changes Oct 19, 2021
View reviewed changes
Copy link
Member

@japaric japaric left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good! (but needs a rebase)

@Urhengulas
Copy link
Member Author

bors r=japaric

@bors
Copy link
Contributor

bors bot commented Oct 19, 2021

Build succeeded:

@bors bors bot merged commit da1682f into main Oct 19, 2021
@bors bors bot deleted the migration-guide branch October 19, 2021 17:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@japaric japaric japaric approved these changes

@justahero justahero Awaiting requested review from justahero

Assignees

@justahero justahero

Labels
None yet
Projects
None yet
Milestone
v0.3.0
Development

Successfully merging this pull request may close these issues.

write a 0.2.x -> 0.3.0 migration guide
3 participants
@Urhengulas @japaric @justahero