add CI to build, check fmt and use in example app #6
Conversation
Lotterleben
changed the title
|
ugh, forgot about my own todos, sorry |
Lotterleben
requested review from
japaric and
jonas-schievink
and removed request for
japaric
| run: | | ||
| sudo apt-get update && sudo apt-get install libssl-dev | ||
| rustup target add ${{ env.CORE_TARGET }} | ||
| cargo install cargo-generate |
There was a problem hiding this comment.
this can take a while to compile (and maybe annoying to compile on Windows). I think it may be cheaper to git clone the app-template and then use sed or similar to update placeholders like {crate_name}.
There was a problem hiding this comment.
aaah good point. we could just do this with a second patch. Pr #2 in 3..2..1.. :)
.github/workflows/ci.yml
Outdated
| #- nightly | ||
| os: | ||
| - ubuntu-latest | ||
| # FIXME: Reenable macOS, Windows, and nightly once demt-test is open-sourced. |
There was a problem hiding this comment.
flip-link is public so we can enable windows and mac right away
| run: | | ||
| cargo generate --git https://github.com/knurling-rs/app-template --branch main --name ${{ env.APPNAME }} | ||
| cd ${{ env.APPNAME }} | ||
| git apply ../.github/workflows/0001-configure-test-flip-link-app-for-nrf52840.patch |
There was a problem hiding this comment.
I was originally thinking of committing an initialized app-template instead of generating a new one on each CI. I think this approach (fetch a new one on each run) is better (at least as long as the app has git dependencies) because we'll get an error (the CI will fail) if the patch stops applying. Perhaps we should also set up a cron job to run CI on a daily basis to catch changes in app-template
opening as PR to check if the CI runs actually run.
still missing: app-template stuff
closes #5 once it's done