Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

supporting json path #2

Open
nestoru opened this issue Oct 29, 2012 · 1 comment
Open

supporting json path #2

nestoru opened this issue Oct 29, 2012 · 1 comment

Comments

@nestoru
Copy link

nestoru commented Oct 29, 2012

Hi Kamiar,

I am wondering if it makes sense to you the following changes (I might be able to fork this and enhance it but first I would like to know your opinion)

  1. Is the button "Save" label actually self explanatory? I think all that button does is to actually "load" the pasted json string into the tree.
  2. Instead of label "Label" doesn't it make sense to have as label "JsonPath" instead?
  3. Then "JsonPath" field should be editable so we can get just a fraction of the json we loaded corresponding to the specified JsonPath

Thanks for reading. Your feedback is appreciated.

-Nestor

@nestoru
Copy link
Author

nestoru commented Oct 29, 2012

forget about point 1. I just figured this is actually to locally save the json. Points 2 and 3 are still relevant as I would like to add json path support.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant