Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Layout test does not seem to work on mac? #256

Closed
n3wscott opened this issue Dec 4, 2020 · 3 comments · Fixed by #384
Closed

Layout test does not seem to work on mac? #256

n3wscott opened this issue Dec 4, 2020 · 3 comments · Fixed by #384

Comments

@n3wscott
Copy link
Contributor

n3wscott commented Dec 4, 2020 

--- FAIL: TestLayout (0.01s)
    layout_test.go:44: Publish() = repository can only contain the runes `abcdefghijklmnopqrstuvwxyz0123456789_-./`: /var/folders/nc/kbpv1klx3gn9mkgdvwq3c40w0000gp/T/ko566747646

it seems the issue is the temp filter contains a T
@jonjohnsonjr
Copy link
Collaborator

Yep, LayoutPublisher.Publish needs a ToLower in there (like the other publishers)... PRs welcome? 😄

@jonjohnsonjr
Copy link
Collaborator

Also needs a TrimPrefix of ko:// it seems?

@github-actions
Copy link

github-actions bot commented Mar 5, 2021

This issue is stale because it has been open for 90 days with no
activity. It will automatically close after 30 more days of
inactivity. Reopen the issue with /reopen. Mark the issue as
fresh by adding the comment /remove-lifecycle stale.

@github-actions github-actions bot closed this as completed Apr 5, 2021
@imjasonh imjasonh reopened this Jul 15, 2021
@imjasonh imjasonh mentioned this issue Jul 15, 2021
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Fix layout tests on macos imjasonh/ko
3 participants
@imjasonh @jonjohnsonjr @n3wscott