Implement Korpus.get_all_texts (#59) #68
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull Request
Korpora에 기여해 주셔서 감사합니다.
해당 Pull Request를 제출하기 전에 아래 사항이 완료되었는지 확인 부탁드립니다:
Korpora/test
)1. 해당 PR은 어떤 내용인가요?
KorpusData
가 하나인 경우에는get_all_texts
를 구현하지 않아도Korpus
의 attribute 중KorpusData
를 상속하는 클래스를 찾아 texts 를 가져옵니다.만약
get_all_texts
에서 return 하는 텍스트의 순서를 강제하고 싶은 경우에는 Korpus 를 상속한 각 클래스별로get_all_texts
를 오버라이딩합니다.2. PR과 관련된 이슈가 있나요?
#59